| Subject | Re: [PATCH 004/190] Revert "media: exynos4-is: Fix several reference count leaks due to pm_runtime_get_sync" | From | Krzysztof Kozlowski <> | Date | Fri, 23 Apr 2021 09:03:09 +0200 |
| |
On 21/04/2021 14:57, Greg Kroah-Hartman wrote: > This reverts commit 7ef64ceea0008c17e94a8a2c60c5d6d46f481996. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Qiushi Wu <wu000273@umn.edu> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/media/platform/exynos4-is/fimc-isp.c | 4 +--- > drivers/media/platform/exynos4-is/fimc-lite.c | 2 +- > 2 files changed, 2 insertions(+), 4 deletions(-) >
This looks like a good commit but should be done now in a different way - using pm_runtime_resume_and_get(). Therefore I am fine with revert and I can submit later better fix.
Best regards, Krzysztof
|