lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 008/190] Revert "media: stm32-dcmi: Fix a reference count leak"
    Date
    This reverts commit 88f50a05f907d96a27a9ce3cc9e8cbb91a6f0f22.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/platform/stm32/stm32-dcmi.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
    index d9b4ad0abf0c..37a10885d79b 100644
    --- a/drivers/media/platform/stm32/stm32-dcmi.c
    +++ b/drivers/media/platform/stm32/stm32-dcmi.c
    @@ -727,7 +727,7 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)
    if (ret < 0) {
    dev_err(dcmi->dev, "%s: Failed to start streaming, cannot get sync (%d)\n",
    __func__, ret);
    - goto err_pm_put;
    + goto err_release_buffers;
    }

    ret = media_pipeline_start(&dcmi->vdev->entity, &dcmi->pipeline);
    @@ -848,6 +848,8 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count)

    err_pm_put:
    pm_runtime_put(dcmi->dev);
    +
    +err_release_buffers:
    spin_lock_irq(&dcmi->irqlock);
    /*
    * Return all buffers to vb2 in QUEUED state.
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:10    [W:2.038 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site