Messages in this thread | | | Date | Tue, 27 Apr 2021 16:53:03 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 143/190] Revert "power: twl4030: fix a missing check of return value" |
| |
On Wed, Apr 21, 2021 at 06:14:07PM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Apr 21, 2021 at 03:00:18PM +0200, Greg Kroah-Hartman wrote: > > This reverts commit 6f12e46eebf1a7d4fdd66df5e815df96b8f8b1b5. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu <kjlu@umn.edu> > > Cc: Sebastian Reichel <sebastian.reichel@collabora.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > Doing another review: > > twl4030 is an I2C connected PMIC, so any read operation can > result in -EIO. If this happens 's' will not be initialized, > so without handling the error is_charging will be set to an > arbitrary state in the following lines. Exiting early from > twl4030_bci_get_property is ok and other HW read operation > failures in the same function are exiting early with proper > error code (as the patch introduced for the only read missing > this). > > TL;DR: original patch is ok, I suggest to drop the revert.
Thanks for the review, now dropped.
greg k-h
| |