Messages in this thread | | | Date | Thu, 29 Apr 2021 21:57:25 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 011/190] Revert "media: platform: fcp: Fix a reference count leak." |
| |
Hi! > --- a/drivers/media/platform/rcar-fcp.c > +++ b/drivers/media/platform/rcar-fcp.c > @@ -102,10 +102,8 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp) > return 0; > > ret = pm_runtime_get_sync(fcp->dev); > - if (ret < 0) { > - pm_runtime_put_noidle(fcp->dev); > + if (ret < 0) > return ret; > - } > > return 0; > }
This one, 12/, 13/ 14/ of the series look correct to me, and should NOT be reverted.
Additinaly 19/, 21/, 27/, 30/, 32/, 33/ and 62/ looked correct to me, but you already decided they should be kept, so no action needs to be done there.
Best regards, Pavel -- http://www.livejournal.com/~pavelmachek [unhandled content-type:application/pgp-signature] | |