lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 039/190] Revert "iommu: Fix reference count leak in iommu_group_alloc."
    Date
    This reverts commit 7cc31613734c4870ae32f5265d576ef296621343.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: https
    Cc: Joerg Roedel <jroedel@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iommu/iommu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
    index d0b0a15dba84..cd22cd0e6517 100644
    --- a/drivers/iommu/iommu.c
    +++ b/drivers/iommu/iommu.c
    @@ -596,7 +596,7 @@ struct iommu_group *iommu_group_alloc(void)
    NULL, "%d", group->id);
    if (ret) {
    ida_simple_remove(&iommu_group_ida, group->id);
    - kobject_put(&group->kobj);
    + kfree(group);
    return ERR_PTR(ret);
    }

    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:10    [W:2.678 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site