lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 115/190] Revert "thunderbolt: Fix a missing check of kmemdup"
    On Wed, Apr 21, 2021 at 02:59:50PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit e4dfdd5804cce1255f99c5dd033526a18135a616.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.

    This one too is valid.

    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/thunderbolt/property.c | 4 ----
    > 1 file changed, 4 deletions(-)
    >
    > diff --git a/drivers/thunderbolt/property.c b/drivers/thunderbolt/property.c
    > index 841314deb446..ee76449524a3 100644
    > --- a/drivers/thunderbolt/property.c
    > +++ b/drivers/thunderbolt/property.c
    > @@ -176,10 +176,6 @@ static struct tb_property_dir *__tb_property_parse_dir(const u32 *block,
    > } else {
    > dir->uuid = kmemdup(&block[dir_offset], sizeof(*dir->uuid),
    > GFP_KERNEL);
    > - if (!dir->uuid) {
    > - tb_property_free_dir(dir);
    > - return NULL;
    > - }
    > content_offset = dir_offset + 4;
    > content_len = dir_len - 4; /* Length includes UUID */
    > }
    > --
    > 2.31.1

    \
     
     \ /
      Last update: 2021-04-22 13:31    [W:2.703 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site