Messages in this thread | | | Date | Tue, 27 Apr 2021 16:13:33 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 177/190] Revert "hwmon: (lm80) fix a missing check of bus read in lm80 probe" |
| |
On Wed, Apr 21, 2021 at 07:03:42AM -0700, Guenter Roeck wrote: > On 4/21/21 6:00 AM, Greg Kroah-Hartman wrote: > > This reverts commit 9aa3aa15f4c2f74f47afd6c5db4b420fadf3f315. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu <kjlu@umn.edu> > > Cc: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Acked-by: Guenter Roeck <linux@roeck-us.net> > > I don't immediately see a problem with this patch, but the other patch > introduced at the same time by the same author was indeed malicious, > and the bug it introduced was easy to overlook, so I agree that > this patch should be reverted. > > [ When introducing error handling into this probe function, errors > in lm80_init_client() should be addressed as well. This patch did > not do that and thus had limited value anyway. ]
Thanks for the review!
greg k-h
| |