| Date | Tue, 27 Apr 2021 20:39:59 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 063/190] Revert "hdlcdrv: replace unnecessary assertion in hdlcdrv_register" |
| |
On Wed, Apr 21, 2021 at 02:58:58PM +0200, Greg Kroah-Hartman wrote: > This reverts commit a886ca6fcfffd337482352f383c1002c72786b17. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Aditya Pakki <pakki001@umn.edu> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/net/hamradio/hdlcdrv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c > index 9e0058154ac3..d8df4e2b162e 100644 > --- a/drivers/net/hamradio/hdlcdrv.c > +++ b/drivers/net/hamradio/hdlcdrv.c > @@ -687,6 +687,8 @@ struct net_device *hdlcdrv_register(const struct hdlcdrv_ops *ops, > struct hdlcdrv_state *s; > int err; > > + BUG_ON(ops == NULL); > + > if (privsize < sizeof(struct hdlcdrv_state)) > privsize = sizeof(struct hdlcdrv_state); > > -- > 2.31.1 >
Original was fine, dropping the revert now.
greg k-h
|