Messages in this thread | | | Subject | Re: [PATCH 162/190] Revert "dmaengine: qcom_hidma: Check for driver register failure" | From | Sinan Kaya <> | Date | Tue, 27 Apr 2021 15:03:28 -0400 |
| |
On 4/27/2021 10:47 AM, Greg Kroah-Hartman wrote: > The original change is NOT correct, as it does not correctly unwind from > the resources that was allocated before the call to > platform_driver_register(). > > As platform_driver_register() should never really fail here, I'll just > revert this patch and maybe someone, if they care about this driver, can > unwind the mess here. Given that this driver doesn't look to ever be > able to be unloaded from the system, failing the init call does not look > to be a wise idea.
Please go ahead. I was out-of-office for the last few days.
| |