Messages in this thread | | | Date | Wed, 21 Apr 2021 16:28:02 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH 142/190] Revert "rtc: hym8563: fix a missing check of block data read" |
| |
Hello,
On 21/04/2021 15:00:17+0200, Greg Kroah-Hartman wrote: > This reverts commit 9a20b5e35a536d6bb4b2d4a3b14a0457e205356c. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. >
There is really nothing wrong in the patch, it was not completely useful but not wrong either.
> Cc: Kangjie Lu <kjlu@umn.edu> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/rtc/rtc-hym8563.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c > index 0751cae27285..a9d033eff61e 100644 > --- a/drivers/rtc/rtc-hym8563.c > +++ b/drivers/rtc/rtc-hym8563.c > @@ -94,8 +94,6 @@ static int hym8563_rtc_read_time(struct device *dev, struct rtc_time *tm) > int ret; > > ret = i2c_smbus_read_i2c_block_data(client, HYM8563_SEC, 7, buf); > - if (ret < 0) > - return ret; > > if (buf[0] & HYM8563_SEC_VL) { > dev_warn(&client->dev, > -- > 2.31.1 >
-- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |