lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 094/190] Revert "iio: adc: fix a potential NULL pointer dereference"
    On Wed, 21 Apr 2021 14:59:29 +0200
    Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

    > This reverts commit 13814627c9658cf8382dd052bc251ee415670a55.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    Checked. Original patch was valid. Don't mind how we handle it though.
    Can bring back later if it's dropped for now.

    Thanks,

    Jonathan

    > ---
    > drivers/iio/adc/mxs-lradc-adc.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/iio/adc/mxs-lradc-adc.c b/drivers/iio/adc/mxs-lradc-adc.c
    > index 30e29f44ebd2..7f327ae95739 100644
    > --- a/drivers/iio/adc/mxs-lradc-adc.c
    > +++ b/drivers/iio/adc/mxs-lradc-adc.c
    > @@ -456,8 +456,6 @@ static int mxs_lradc_adc_trigger_init(struct iio_dev *iio)
    >
    > trig = devm_iio_trigger_alloc(&iio->dev, "%s-dev%i", iio->name,
    > iio->id);
    > - if (!trig)
    > - return -ENOMEM;
    >
    > trig->dev.parent = adc->dev;
    > iio_trigger_set_drvdata(trig, iio);

    \
     
     \ /
      Last update: 2021-04-22 10:34    [W:2.060 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site