| Date | Tue, 27 Apr 2021 20:17:00 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 144/190] Revert "misc/ics932s401: Add a missing check to i2c_smbus_read_word_data" |
| |
On Wed, Apr 21, 2021 at 03:00:19PM +0200, Greg Kroah-Hartman wrote: > This reverts commit b05ae01fdb8966afff5b153e7a7ee24684745e2d. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Aditya Pakki <pakki001@umn.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/misc/ics932s401.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/misc/ics932s401.c b/drivers/misc/ics932s401.c > index 2bdf560ee681..733e5c2b57ce 100644 > --- a/drivers/misc/ics932s401.c > +++ b/drivers/misc/ics932s401.c > @@ -133,8 +133,6 @@ static struct ics932s401_data *ics932s401_update_device(struct device *dev) > */ > for (i = 0; i < NUM_MIRRORED_REGS; i++) { > temp = i2c_smbus_read_word_data(client, regs_to_copy[i]); > - if (temp < 0) > - data->regs[regs_to_copy[i]] = 0; > data->regs[regs_to_copy[i]] = temp >> 8; > } > > -- > 2.31.1 >
While ackward, the original looks good enough for now, so I'll drop this revert.
greg k-h
|