Messages in this thread | | | Date | Tue, 27 Apr 2021 18:34:42 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 078/190] Revert "ASoC: cs43130: fix a NULL pointer dereference" |
| |
On Wed, Apr 21, 2021 at 02:59:13PM +0200, Greg Kroah-Hartman wrote: > This reverts commit a2be42f18d409213bb7e7a736e3ef6ba005115bb. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu <kjlu@umn.edu> > Cc: Mark Brown <broonie@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > sound/soc/codecs/cs43130.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c > index 80bc7c10ed75..c2b6f0ae6d57 100644 > --- a/sound/soc/codecs/cs43130.c > +++ b/sound/soc/codecs/cs43130.c > @@ -2319,8 +2319,6 @@ static int cs43130_probe(struct snd_soc_component *component) > return ret; > > cs43130->wq = create_singlethread_workqueue("cs43130_hp"); > - if (!cs43130->wq) > - return -ENOMEM; > INIT_WORK(&cs43130->work, cs43130_imp_meas); > } > > -- > 2.31.1 >
The original patch here is not correct, lots of resources are allocated and files created that are not unwound. I will keep this revert and fix it up "properly".
thanks,
greg k-h
| |