Messages in this thread | | | Date | Tue, 27 Apr 2021 16:37:31 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 108/190] Revert "usb: u132-hcd: fix potential NULL pointer dereference" |
| |
On Wed, Apr 21, 2021 at 02:59:43PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 3de3dbe7c13210171ba8411e36b409a2c29c7415. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu <kjlu@umn.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/usb/host/u132-hcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c > index eb96e1e15b71..2b7bcbe2df4b 100644 > --- a/drivers/usb/host/u132-hcd.c > +++ b/drivers/usb/host/u132-hcd.c > @@ -3195,8 +3195,6 @@ static int __init u132_hcd_init(void) > return -ENODEV; > printk(KERN_INFO "driver %s\n", hcd_name); > workqueue = create_singlethread_workqueue("u132"); > - if (!workqueue) > - return -ENOMEM; > retval = platform_driver_register(&u132_platform_driver); > if (retval) > destroy_workqueue(workqueue); > -- > 2.31.1 >
This commit was correct, will drop this.
greg k-h
| |