lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 183/190] Revert "media: isif: fix a NULL pointer dereference bug"
    Date
    This reverts commit a26ac6c1bed951b2066cc4b2257facd919e35c0b.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Wenwen Wang <wang6495@umn.edu>
    Cc: Hans Verkuil <hverkuil@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/platform/davinci/isif.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/platform/davinci/isif.c b/drivers/media/platform/davinci/isif.c
    index c53cecd072b1..5355a14c090b 100644
    --- a/drivers/media/platform/davinci/isif.c
    +++ b/drivers/media/platform/davinci/isif.c
    @@ -1086,8 +1086,7 @@ static int isif_probe(struct platform_device *pdev)

    while (i >= 0) {
    res = platform_get_resource(pdev, IORESOURCE_MEM, i);
    - if (res)
    - release_mem_region(res->start, resource_size(res));
    + release_mem_region(res->start, resource_size(res));
    i--;
    }
    vpfe_unregister_ccdc_device(&isif_hw_dev);
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:21    [W:2.266 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site