lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 025/190] Revert "platform/chrome: cros_ec_ishtp: Fix a double-unlock issue"
    Date
    This reverts commit aaa3cbbac326c95308e315f1ab964a3369c4d07d.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: Mathew King <mathewk@chromium.org>
    Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/platform/chrome/cros_ec_ishtp.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
    index f00107017318..d4f41d68232c 100644
    --- a/drivers/platform/chrome/cros_ec_ishtp.c
    +++ b/drivers/platform/chrome/cros_ec_ishtp.c
    @@ -677,10 +677,8 @@ static int cros_ec_ishtp_probe(struct ishtp_cl_device *cl_device)

    /* Register croc_ec_dev mfd */
    rv = cros_ec_dev_init(client_data);
    - if (rv) {
    - down_write(&init_lock);
    + if (rv)
    goto end_cros_ec_dev_init_error;
    - }

    return 0;

    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:03    [W:2.952 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site