lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 163/190] Revert "dmaengine: mv_xor: Fix a missing check in mv_xor_channel_add"
    Date
    This reverts commit 7c97381e7a9a5ec359007c0d491a143e3d9f787c.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/mv_xor.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
    index 23b232b57518..78bd52565571 100644
    --- a/drivers/dma/mv_xor.c
    +++ b/drivers/dma/mv_xor.c
    @@ -1144,10 +1144,7 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
    dma_has_cap(DMA_MEMCPY, dma_dev->cap_mask) ? "cpy " : "",
    dma_has_cap(DMA_INTERRUPT, dma_dev->cap_mask) ? "intr " : "");

    - ret = dma_async_device_register(dma_dev);
    - if (ret)
    - goto err_free_irq;
    -
    + dma_async_device_register(dma_dev);
    return mv_chan;

    err_free_irq:
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:39    [W:3.697 / U:0.864 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site