| Subject | Re: [PATCH 070/190] Revert "rfkill: Fix incorrect check to avoid NULL pointer dereference" | From | Johannes Berg <> | Date | Wed, 21 Apr 2021 15:43:31 +0200 |
| |
On Wed, 2021-04-21 at 12:59 +0000, Greg Kroah-Hartman wrote: > This reverts commit 6fc232db9e8cd50b9b83534de9cd91ace711b2d7.
This commit was fine, though the commit log is misleading since there's no dereference yet, just a pointer calculation. I may not have seen that at the time, or have decided that the slight commit log inaccuracy didn't matter.
I'm inclined towards keeping it, since it removed a BUG_ON(), but there's no reasonable scenario where somebody could end up calling this function with a NULL pointer.
johannes
|