lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 003/190] Revert "media: sti: Fix reference count leaks"
    Date
    This reverts commit 6f4432bae9f2d12fc1815b5e26cc07e69bcad0df.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/platform/sti/hva/hva-hw.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
    index f59811e27f51..d0d45dc5f32f 100644
    --- a/drivers/media/platform/sti/hva/hva-hw.c
    +++ b/drivers/media/platform/sti/hva/hva-hw.c
    @@ -272,7 +272,6 @@ static unsigned long int hva_hw_get_ip_version(struct hva_dev *hva)

    if (pm_runtime_get_sync(dev) < 0) {
    dev_err(dev, "%s failed to get pm_runtime\n", HVA_PREFIX);
    - pm_runtime_put_noidle(dev);
    mutex_unlock(&hva->protect_mutex);
    return -EFAULT;
    }
    @@ -555,7 +554,6 @@ void hva_hw_dump_regs(struct hva_dev *hva, struct seq_file *s)

    if (pm_runtime_get_sync(dev) < 0) {
    seq_puts(s, "Cannot wake up IP\n");
    - pm_runtime_put_noidle(dev);
    mutex_unlock(&hva->protect_mutex);
    return;
    }
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:02    [W:2.902 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site