lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 014/190] Revert "media: rcar-vin: Fix a reference count leak."
    Date
    This reverts commit aaffa0126a111d65f4028c503c76192d4cc93277.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/platform/rcar-vin/rcar-dma.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c
    index f30dafbdf61c..e109b3d0f4d1 100644
    --- a/drivers/media/platform/rcar-vin/rcar-dma.c
    +++ b/drivers/media/platform/rcar-vin/rcar-dma.c
    @@ -1459,10 +1459,8 @@ int rvin_set_channel_routing(struct rvin_dev *vin, u8 chsel)
    int ret;

    ret = pm_runtime_get_sync(vin->dev);
    - if (ret < 0) {
    - pm_runtime_put_noidle(vin->dev);
    + if (ret < 0)
    return ret;
    - }

    /* Make register writes take effect immediately. */
    vnmc = rvin_read(vin, VNMC_REG);
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:02    [W:4.135 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site