lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 149/190] Revert "media: lgdt3306a: fix a missing check of return value"
    Date
    This reverts commit c9b7d8f252a5a6f8ca6e948151367cbc7bc4b776.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Kangjie Lu <kjlu@umn.edu>
    Cc: Sean Young <sean@mess.org>
    Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/dvb-frontends/lgdt3306a.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
    index 722576f1732a..f34263a33ede 100644
    --- a/drivers/media/dvb-frontends/lgdt3306a.c
    +++ b/drivers/media/dvb-frontends/lgdt3306a.c
    @@ -1690,10 +1690,7 @@ static int lgdt3306a_read_signal_strength(struct dvb_frontend *fe,
    case QAM_256:
    case QAM_AUTO:
    /* need to know actual modulation to set proper SNR baseline */
    - ret = lgdt3306a_read_reg(state, 0x00a6, &val);
    - if (lg_chkerr(ret))
    - goto fail;
    -
    + lgdt3306a_read_reg(state, 0x00a6, &val);
    if(val & 0x04)
    ref_snr = 2800; /* QAM-256 28dB */
    else
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:39    [W:4.585 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site