lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 167/190] Revert "gdrom: fix a memory leak bug"
    From
    Date
    > This reverts commit 093c48213ee37c3c3ff1cf5ac1aa2a9d8bc66017.

    The reverted patch looks fishy.

    gc.cd_info is kzalloc:ed on probe. In case probe fails after this allocation, the
    memory is kfree:d but the variable is NOT zeroed out.

    AFAICT, the above leads to a double-free on exit by the added line.

    I believe gd.cd_info should be kfree:d on remove instead.

    However, might not gc.toc also be kfree:d twice for similar reasons?

    I could easily be mistaken.

    Cheers,
    Peter

    \
     
     \ /
      Last update: 2021-04-22 23:33    [W:3.964 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site