Messages in this thread | | | Date | Tue, 27 Apr 2021 16:25:11 +0200 | From | Greg KH <> | Subject | Re: [PATCH 044/190] Revert "RDMA/pvrdma: Fix missing pci disable in pvrdma_pci_probe()" |
| |
On Wed, Apr 21, 2021 at 12:25:17PM -0700, Roland Dreier wrote: > This is a really weird one because the patch actually looks correct > and the revert looks wrong?? > > ret = pci_enable_device(pdev); > > [...dbg statements...] > > if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) || > !(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) { > dev_err(&pdev->dev, "PCI BAR region not MMIO\n"); > ret = -ENOMEM; > goto err_disable_pdev; > } > > - R.
git revert sometimes does odd things :)
I'll go drop this from the tree, thanks.
greg k-h
| |