lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 099/190] Revert "omapfb: Fix potential NULL pointer dereference in kmalloc"
    Date
    This reverts commit 31fa6e2ae65feed0de10823c5d1eea21a93086c9.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: Kangjie Lu <kjlu@umn.edu>
    Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
    index 0ae0cab252d3..05d87dcbdd8b 100644
    --- a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
    +++ b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
    @@ -100,8 +100,6 @@ static void __init omapdss_omapify_node(struct device_node *node)

    new_len = prop->length + strlen(prefix) * num_strs;
    new_compat = kmalloc(new_len, GFP_KERNEL);
    - if (!new_compat)
    - return;

    omapdss_prefix_strcpy(new_compat, new_len, prop->value, prop->length);

    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:08    [W:2.541 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site