lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 070/190] Revert "rfkill: Fix incorrect check to avoid NULL pointer dereference"
    Date
    This reverts commit 6fc232db9e8cd50b9b83534de9cd91ace711b2d7.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: https
    Cc: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/rfkill/core.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/net/rfkill/core.c b/net/rfkill/core.c
    index ac15a944573f..8a27164d7f5f 100644
    --- a/net/rfkill/core.c
    +++ b/net/rfkill/core.c
    @@ -1033,13 +1033,10 @@ static void rfkill_sync_work(struct work_struct *work)
    int __must_check rfkill_register(struct rfkill *rfkill)
    {
    static unsigned long rfkill_no;
    - struct device *dev;
    + struct device *dev = &rfkill->dev;
    int error;

    - if (!rfkill)
    - return -EINVAL;
    -
    - dev = &rfkill->dev;
    + BUG_ON(!rfkill);

    mutex_lock(&rfkill_global_mutex);

    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:08    [W:4.087 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site