lkml.org 
[lkml]   [2021]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 156/190] Revert "serial: max310x: pass return value of spi_register_driver"
    From
    Date
    On 21. 04. 21, 15:00, Greg Kroah-Hartman wrote:
    > This reverts commit 51f689cc11333944c7a457f25ec75fcb41e99410.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/tty/serial/max310x.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c
    > index 1b61d26bb7af..93f69b66b896 100644
    > --- a/drivers/tty/serial/max310x.c
    > +++ b/drivers/tty/serial/max310x.c
    > @@ -1518,10 +1518,10 @@ static int __init max310x_uart_init(void)
    > return ret;
    >
    > #ifdef CONFIG_SPI_MASTER
    > - ret = spi_register_driver(&max310x_spi_driver);
    > + spi_register_driver(&max310x_spi_driver);
    > #endif
    >
    > - return ret;
    > + return 0;

    ACK, uart_unregister_driver() is missing in case of error at least.

    > }
    > module_init(max310x_uart_init);
    >
    >


    --
    js
    suse labs

    \
     
     \ /
      Last update: 2021-04-22 07:29    [W:4.126 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site