Messages in this thread | | | Date | Tue, 27 Apr 2021 15:25:41 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 148/190] Revert "media: mt312: fix a missing check of mt312 reset" |
| |
On Wed, Apr 21, 2021 at 03:00:23PM +0200, Greg Kroah-Hartman wrote: > This reverts commit 9502cdf0807058a10029488052b064cecceb7fc9. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu <kjlu@umn.edu> > Cc: Matthias Schwarzott <zzam@gentoo.org> > Cc: Sean Young <sean@mess.org> > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/media/dvb-frontends/mt312.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c > index d43a67045dbe..1dc6adefb8fe 100644 > --- a/drivers/media/dvb-frontends/mt312.c > +++ b/drivers/media/dvb-frontends/mt312.c > @@ -627,9 +627,7 @@ static int mt312_set_frontend(struct dvb_frontend *fe) > if (ret < 0) > return ret; > > - ret = mt312_reset(state, 0); > - if (ret < 0) > - return ret; > + mt312_reset(state, 0); > > return 0; > } > -- > 2.31.1 >
This could have been made much simpler: return mt312_reset(state, 0); but as-is, is fine, I'll drop this revert.
greg k-h
| |