lkml.org 
[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 096/190] Revert "net: mwifiex: fix a NULL pointer dereference"
    On Wed, Apr 21, 2021 at 02:59:31PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit e5b9b206f3f6376b9a1406b67eafe4e7bb9f123c.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Kalle Valo <kvalo@codeaurora.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 6 ------
    > 1 file changed, 6 deletions(-)
    >
    > diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
    > index 3a11342a6bde..bda8a236e386 100644
    > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
    > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
    > @@ -339,12 +339,6 @@ static int mwifiex_dnld_sleep_confirm_cmd(struct mwifiex_adapter *adapter)
    > sleep_cfm_tmp =
    > dev_alloc_skb(sizeof(struct mwifiex_opt_sleep_confirm)
    > + MWIFIEX_TYPE_LEN);
    > - if (!sleep_cfm_tmp) {
    > - mwifiex_dbg(adapter, ERROR,
    > - "SLEEP_CFM: dev_alloc_skb failed\n");
    > - return -ENOMEM;
    > - }
    > -
    > skb_put(sleep_cfm_tmp, sizeof(struct mwifiex_opt_sleep_confirm)
    > + MWIFIEX_TYPE_LEN);
    > put_unaligned_le32(MWIFIEX_USB_TYPE_CMD, sleep_cfm_tmp->data);
    > --
    > 2.31.1
    >

    This looks fine, I'll drop this revert.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-28 07:29    [W:3.507 / U:2.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site