lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 104/190] Revert "char: hpet: fix a missing check of ioremap"
    On Wed, Apr 21, 2021 at 02:59:39PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 13bd14a41ce3105d5b1f3cd8b4d1e249d17b6d9b.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/char/hpet.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
    > index ed3b7dab678d..6f13def6c172 100644
    > --- a/drivers/char/hpet.c
    > +++ b/drivers/char/hpet.c
    > @@ -969,8 +969,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
    > if (ACPI_SUCCESS(status)) {
    > hdp->hd_phys_address = addr.address.minimum;
    > hdp->hd_address = ioremap(addr.address.minimum, addr.address.address_length);
    > - if (!hdp->hd_address)
    > - return AE_ERROR;
    >
    > if (hpet_is_known(hdp)) {
    > iounmap(hdp->hd_address);
    > --
    > 2.31.1
    >

    While this is technically correct, it is only fixing ONE of these errors
    in this function, so the patch is not fully correct. I'll leave this
    revert and provide a fix for this later that resolves this same
    "problem" everywhere in this function.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 19:27    [W:4.498 / U:1.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site