lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 050/190] Revert "nfp: abm: fix a memory leak bug"
    On Wed, Apr 21, 2021 at 09:03:15AM -0700, Jakub Kicinski wrote:
    > On Wed, 21 Apr 2021 14:58:45 +0200 Greg Kroah-Hartman wrote:
    > > This reverts commit bd4af432cc71b5fbfe4833510359a6ad3ada250d.
    > >
    > > Commits from @umn.edu addresses have been found to be submitted in "bad
    > > faith" to try to test the kernel community's ability to review "known
    > > malicious" changes. The result of these submissions can be found in a
    > > paper published at the 42nd IEEE Symposium on Security and Privacy
    > > entitled, "Open Source Insecurity: Stealthily Introducing
    > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > > of Minnesota) and Kangjie Lu (University of Minnesota).
    > >
    > > Because of this, all submissions from this group must be reverted from
    > > the kernel tree and will need to be re-reviewed again to determine if
    > > they actually are a valid fix. Until that work is complete, remove this
    > > change to ensure that no problems are being introduced into the
    > > codebase.
    > >
    > > Cc: Qiushi Wu <wu000273@umn.edu>
    > > Cc: Jakub Kicinski <kuba@kernel.org>
    > > Cc: David S. Miller <davem@davemloft.net>
    > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > > ---
    > > drivers/net/ethernet/netronome/nfp/abm/main.c | 1 -
    > > 1 file changed, 1 deletion(-)
    > >
    > > diff --git a/drivers/net/ethernet/netronome/nfp/abm/main.c b/drivers/net/ethernet/netronome/nfp/abm/main.c
    > > index bdbf0726145e..341773b43a4d 100644
    > > --- a/drivers/net/ethernet/netronome/nfp/abm/main.c
    > > +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c
    > > @@ -283,7 +283,6 @@ nfp_abm_vnic_set_mac(struct nfp_pf *pf, struct nfp_abm *abm, struct nfp_net *nn,
    > > if (!nfp_nsp_has_hwinfo_lookup(nsp)) {
    > > nfp_warn(pf->cpp, "NSP doesn't support PF MAC generation\n");
    > > eth_hw_addr_random(nn->dp.netdev);
    > > - nfp_nsp_close(nsp);
    > > return;
    > > }
    > >
    >
    > This one still looks correct to me :S

    Thanks for the review, now dropped.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 16:54    [W:3.177 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site