Messages in this thread | | | Date | Tue, 27 Apr 2021 15:37:24 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 178/190] Revert "net: netxen: fix a missing check and an uninitialized use" |
| |
On Wed, Apr 21, 2021 at 03:00:53PM +0200, Greg Kroah-Hartman wrote: > This reverts commit d134e486e831defd26130770181f01dfc6195f7d. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu <kjlu@umn.edu> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > index 08f9477d2ee8..32b9e28dda16 100644 > --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > @@ -1107,8 +1107,7 @@ netxen_validate_firmware(struct netxen_adapter *adapter) > return -EINVAL; > } > val = nx_get_bios_version(adapter); > - if (netxen_rom_fast_read(adapter, NX_BIOS_VERSION_OFFSET, (int *)&bios)) > - return -EIO; > + netxen_rom_fast_read(adapter, NX_BIOS_VERSION_OFFSET, (int *)&bios); > if ((__force u32)val != bios) { > dev_err(&pdev->dev, "%s: firmware bios is incompatible\n", > fw_name[fw_type]); > -- > 2.31.1 >
This change, while messy and could be better, is semi-sane so I'll drop it from my series.
thanks,
greg k-h
| |