Messages in this thread | | | Date | Tue, 27 Apr 2021 15:40:57 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync" |
| |
On Wed, Apr 21, 2021 at 04:08:05PM +0000, Deucher, Alexander wrote: > [AMD Public Use] > > > -----Original Message----- > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Sent: Wednesday, April 21, 2021 8:58 AM > > To: linux-kernel@vger.kernel.org > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Quan, Evan > > <Evan.Quan@amd.com>; Aditya Pakki <pakki001@umn.edu>; Deucher, > > Alexander <Alexander.Deucher@amd.com> > > Subject: [PATCH 022/190] Revert "drm/radeon: Fix reference count leaks > > caused by pm_runtime_get_sync" > > > > This reverts commit 9fb10671011143d15b6b40d6d5fa9c52c57e9d63. > > > > Commits from @umn.edu addresses have been found to be submitted in > > "bad faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a paper > > published at the 42nd IEEE Symposium on Security and Privacy entitled, > > "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite > > Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu > > (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from the > > kernel tree and will need to be re-reviewed again to determine if they > > actually are a valid fix. Until that work is complete, remove this change to > > ensure that no problems are being introduced into the codebase. > > > > Cc: Evan Quan <evan.quan@amd.com> > > Cc: Aditya Pakki <pakki001@umn.edu> > > Cc: Alex Deucher <alexander.deucher@amd.com> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > AFAICT, this patch is correct or at least does no harm. Handling of pm_runtime_get_sync() errors in the kernel seems to be inconsistent at best.
Thanks for the review, I'll drop this revert from the tree.
greg k-h
| |