lkml.org 
[lkml]   [2021]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 100/190] Revert "staging: greybus: audio_manager: fix a missing check of ida_simple_get"
    On Thu, Apr 22, 2021 at 10:43:45AM +0530, Viresh Kumar wrote:
    > On 21-04-21, 14:59, Greg Kroah-Hartman wrote:
    > > This reverts commit b5af36e3e5aa074605a4d90a89dd8f714b30909b.
    > >
    > > Commits from @umn.edu addresses have been found to be submitted in "bad
    > > faith" to try to test the kernel community's ability to review "known
    > > malicious" changes. The result of these submissions can be found in a
    > > paper published at the 42nd IEEE Symposium on Security and Privacy
    > > entitled, "Open Source Insecurity: Stealthily Introducing
    > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > > of Minnesota) and Kangjie Lu (University of Minnesota).
    > >
    > > Because of this, all submissions from this group must be reverted from
    > > the kernel tree and will need to be re-reviewed again to determine if
    > > they actually are a valid fix. Until that work is complete, remove this
    > > change to ensure that no problems are being introduced into the
    > > codebase.
    > >
    > > Cc: Kangjie Lu <kjlu@umn.edu>
    > > Cc: Vaibhav Agarwal <vaibhav.sr@gmail.com>
    > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
    > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > > ---
    > > drivers/staging/greybus/audio_manager.c | 3 ---
    > > 1 file changed, 3 deletions(-)
    > >
    > > diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c
    > > index 9a3f7c034ab4..7c7ca671876d 100644
    > > --- a/drivers/staging/greybus/audio_manager.c
    > > +++ b/drivers/staging/greybus/audio_manager.c
    > > @@ -45,9 +45,6 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc)
    > > int err;
    > >
    > > id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
    > > - if (id < 0)
    > > - return id;
    > > -
    > > err = gb_audio_manager_module_create(&module, manager_kset,
    > > id, desc);
    > > if (err) {
    >
    > FWIW, this patch was doing the right thing IMO. So we may not want to
    > revert it.

    Thanks for the review, I'll drop this revert.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-26 19:04    [W:5.337 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site