lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 047/190] Revert "rxrpc: Fix a memory leak in rxkad_verify_response()"
    Date
    This reverts commit f45d01f4f30b53c3a0a1c6c1c154acb7ff74ab9f.

    Commits from @umn.edu addresses have been found to be submitted in "bad
    faith" to try to test the kernel community's ability to review "known
    malicious" changes. The result of these submissions can be found in a
    paper published at the 42nd IEEE Symposium on Security and Privacy
    entitled, "Open Source Insecurity: Stealthily Introducing
    Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    of Minnesota) and Kangjie Lu (University of Minnesota).

    Because of this, all submissions from this group must be reverted from
    the kernel tree and will need to be re-reviewed again to determine if
    they actually are a valid fix. Until that work is complete, remove this
    change to ensure that no problems are being introduced into the
    codebase.

    Cc: Qiushi Wu <wu000273@umn.edu>
    Cc: David Howells <dhowells@redhat.com>
    Cc: Markus Elfring <Markus.Elfring@web.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/rxrpc/rxkad.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
    index e2e9e9b0a6d7..6cdbfb4f8cda 100644
    --- a/net/rxrpc/rxkad.c
    +++ b/net/rxrpc/rxkad.c
    @@ -1241,7 +1241,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn,
    ret = rxkad_decrypt_ticket(conn, server_key, skb, ticket, ticket_len,
    &session_key, &expiry, _abort_code);
    if (ret < 0)
    - goto temporary_error_free_ticket;
    + goto temporary_error_free_resp;

    /* use the session key from inside the ticket to decrypt the
    * response */
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-04-21 15:05    [W:4.017 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site