Messages in this thread | | | Date | Wed, 28 Apr 2021 09:11:12 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 031/190] Revert "test_objagg: Fix potential memory leak in error handling" |
| |
On Wed, Apr 21, 2021 at 02:58:26PM +0200, Greg Kroah-Hartman wrote: > This reverts commit a6379f0ad6375a707e915518ecd5c2270afcd395. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Aditya Pakki <pakki001@umn.edu> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > lib/test_objagg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/test_objagg.c b/lib/test_objagg.c > index da137939a410..72c1abfa154d 100644 > --- a/lib/test_objagg.c > +++ b/lib/test_objagg.c > @@ -979,10 +979,10 @@ static int test_hints_case(const struct hints_case *hints_case) > err_world2_obj_get: > for (i--; i >= 0; i--) > world_obj_put(&world2, objagg, hints_case->key_ids[i]); > - i = hints_case->key_ids_count; > + objagg_hints_put(hints); > objagg_destroy(objagg2); > + i = hints_case->key_ids_count; > err_check_expect_hints_stats: > - objagg_hints_put(hints); > err_hints_get: > err_check_expect_stats: > err_world_obj_get: > -- > 2.31.1 >
This commit looks correct to me, so I will drop the revert.
greg k-h
| |