lkml.org 
[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 091/190] Revert "pinctrl: axp209: Fix NULL pointer dereference after allocation"
    On Wed, Apr 21, 2021 at 02:59:26PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit 1adc90c7395742827d754a5f02f446818a77c379.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Aditya Pakki <pakki001@umn.edu>
    > Cc: Linus Walleij <linus.walleij@linaro.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/pinctrl/pinctrl-axp209.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp209.c
    > index 207cbae3a7bf..58f7149dd39b 100644
    > --- a/drivers/pinctrl/pinctrl-axp209.c
    > +++ b/drivers/pinctrl/pinctrl-axp209.c
    > @@ -365,8 +365,6 @@ static int axp20x_build_funcs_groups(struct platform_device *pdev)
    > pctl->funcs[i].groups = devm_kcalloc(&pdev->dev,
    > npins, sizeof(char *),
    > GFP_KERNEL);
    > - if (!pctl->funcs[i].groups)
    > - return -ENOMEM;
    > for (pin = 0; pin < npins; pin++)
    > pctl->funcs[i].groups[pin] = pctl->desc->pins[pin].name;
    > }
    > --
    > 2.31.1
    >

    This change looks correct, dropping the revert from my tree.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-28 16:33    [W:2.934 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site