lkml.org 
[lkml]   [2021]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 174/190] Revert "net: chelsio: Add a missing check on cudg_get_buffer"
    On Wed, Apr 21, 2021 at 03:00:49PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit ca19fcb6285bfce1601c073bf4b9d2942e2df8d9.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper published at the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota).
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Aditya Pakki <pakki001@umn.edu>
    > Cc: David S. Miller <davem@davemloft.net>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > ---
    > drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 4 ----
    > 1 file changed, 4 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
    > index 23a2ebdfd503..c7378da78a83 100644
    > --- a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
    > +++ b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
    > @@ -1638,10 +1638,6 @@ int cudbg_collect_hw_sched(struct cudbg_init *pdbg_init,
    >
    > rc = cudbg_get_buff(pdbg_init, dbg_buff, sizeof(struct cudbg_hw_sched),
    > &temp_buff);
    > -
    > - if (rc)
    > - return rc;
    > -
    > hw_sched_buff = (struct cudbg_hw_sched *)temp_buff.data;
    > hw_sched_buff->map = t4_read_reg(padap, TP_TX_MOD_QUEUE_REQ_MAP_A);
    > hw_sched_buff->mode = TIMERMODE_G(t4_read_reg(padap, TP_MOD_CONFIG_A));
    > --
    > 2.31.1
    >

    Original looks correct, dropping this revert.

    greg k-h

    \
     
     \ /
      Last update: 2021-04-27 19:01    [W:3.961 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site