Messages in this thread | | | Date | Mon, 26 Apr 2021 19:00:07 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 101/190] Revert "PCI: xilinx: Check for __get_free_pages() failure" |
| |
On Thu, Apr 22, 2021 at 11:42:24AM +0100, Lorenzo Pieralisi wrote: > On Wed, Apr 21, 2021 at 02:59:36PM +0200, Greg Kroah-Hartman wrote: > > This reverts commit 699ca30162686bf305cdf94861be02eb0cf9bda2. > > > > Commits from @umn.edu addresses have been found to be submitted in "bad > > faith" to try to test the kernel community's ability to review "known > > malicious" changes. The result of these submissions can be found in a > > paper published at the 42nd IEEE Symposium on Security and Privacy > > entitled, "Open Source Insecurity: Stealthily Introducing > > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > > of Minnesota) and Kangjie Lu (University of Minnesota). > > > > Because of this, all submissions from this group must be reverted from > > the kernel tree and will need to be re-reviewed again to determine if > > they actually are a valid fix. Until that work is complete, remove this > > change to ensure that no problems are being introduced into the > > codebase. > > > > Cc: Kangjie Lu <kjlu@umn.edu> > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > Cc: Steven Price <steven.price@arm.com> > > Cc: Mukesh Ojha <mojha@codeaurora.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/pci/controller/pcie-xilinx.c | 12 ++---------- > > 1 file changed, 2 insertions(+), 10 deletions(-) > > Hi Greg, > > For this revert - the commit we are reverting looked and looks OK > to me even though honestly I'd revert it just on principle given > the nuisance it is causing. > > Actually, we have code in -next that is removing the reverted content > anyway (but not because it is bogus, code in -next is a nice clean-up > for all PCI drivers from Marc): > > https://git.kernel.org/lpieralisi/pci/c/161260e7f7bc > > Again, happy to go ahead with the revert and rework the queued code > on top of it, just let me know please.
I'll just drop this revert from my tree so as to not mess up your follow-up cleanups, thanks for the review!
greg k-h
| |