lkml.org 
[lkml]   [2021]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 057/141] watchdog: Fix fall-through warnings for Clang
    Hi all,

    It's been more than 3 months; who can take this, please? :)

    Thanks
    --
    Gustavo

    On Fri, Nov 20, 2020 at 12:32:51PM -0600, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a fallthrough pseudo-keyword instead of letting the
    > code fall through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > drivers/watchdog/machzwd.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/watchdog/machzwd.c b/drivers/watchdog/machzwd.c
    > index 743377c5b173..73f2221f6222 100644
    > --- a/drivers/watchdog/machzwd.c
    > +++ b/drivers/watchdog/machzwd.c
    > @@ -174,6 +174,7 @@ static inline void zf_set_timer(unsigned short new, unsigned char n)
    > fallthrough;
    > case WD2:
    > zf_writeb(COUNTER_2, new > 0xff ? 0xff : new);
    > + fallthrough;
    > default:
    > return;
    > }
    > --
    > 2.27.0
    >

    \
     
     \ /
      Last update: 2021-03-05 00:04    [W:4.100 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site