lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 072/141] can: peak_usb: Fix fall-through warnings for Clang
    From
    Date
    On 11/20/20 7:34 PM, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a break statement instead of letting the code fall
    > through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > index c2764799f9ef..fd65a155be3b 100644
    > --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    > @@ -299,6 +299,8 @@ static void peak_usb_write_bulk_callback(struct urb *urb)
    > if (net_ratelimit())
    > netdev_err(netdev, "Tx urb aborted (%d)\n",
    > urb->status);
    > + break;
    > +
    > case -EPROTO:
    > case -ENOENT:
    > case -ECONNRESET:
    >

    What about moving the default to the end if the case, which is more common anyways:

    diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    index 204ccb27d6d9..e8977dd10902 100644
    --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
    @@ -295,16 +295,16 @@ static void peak_usb_write_bulk_callback(struct urb *urb)
    netif_trans_update(netdev);
    break;

    - default:
    - if (net_ratelimit())
    - netdev_err(netdev, "Tx urb aborted (%d)\n",
    - urb->status);
    case -EPROTO:
    case -ENOENT:
    case -ECONNRESET:
    case -ESHUTDOWN:
    -
    break;
    +
    + default:
    + if (net_ratelimit())
    + netdev_err(netdev, "Tx urb aborted (%d)\n",
    + urb->status);
    }

    /* should always release echo skb and corresponding context */

    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

    Marc

    --
    Pengutronix e.K. | Marc Kleine-Budde |
    Embedded Linux | https://www.pengutronix.de |
    Vertretung West/Dortmund | Phone: +49-231-2826-924 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-11-21 14:20    [W:2.522 / U:2.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site