Messages in this thread Patch in this message |  | | Subject | Re: [PATCH 032/141] floppy: Fix fall-through warnings for Clang | From | Denis Efremov <> | Date | Tue, 20 Apr 2021 23:34:19 +0300 |
| |
Hi,
Sorry, this was missed somehow.
I would rewrite it to something more simple instead of adding fallthrough.
What about?
--- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -2123,12 +2123,14 @@ static void set_floppy(int drive) static void format_interrupt(void) { switch (interpret_errors()) { + case 0: + cont->done(1); + break; case 1: cont->error(); + break; case 2: break; - case 0: - cont->done(1); } cont->redo(); } On 4/20/21 11:25 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 11/20/20 12:28, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning >> by explicitly adding a fallthrough pseudo-keyword in places where the >> code is intended to fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/block/floppy.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c >> index 7df79ae6b0a1..21a2a7becba0 100644 >> --- a/drivers/block/floppy.c >> +++ b/drivers/block/floppy.c >> @@ -2124,6 +2124,7 @@ static void format_interrupt(void) >> switch (interpret_errors()) { >> case 1: >> cont->error(); >> + fallthrough; >> case 2: >> break; >> case 0: >>
|  |