lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 007/141] gpio: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding a break and a fallthrough statements
    instead of just letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/gpio/gpio-ath79.c | 1 +
    drivers/gpio/gpiolib-acpi.c | 1 +
    2 files changed, 2 insertions(+)

    diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
    index d5359341cc6b..678ddd375891 100644
    --- a/drivers/gpio/gpio-ath79.c
    +++ b/drivers/gpio/gpio-ath79.c
    @@ -123,6 +123,7 @@ static int ath79_gpio_irq_set_type(struct irq_data *data,
    switch (flow_type) {
    case IRQ_TYPE_EDGE_RISING:
    polarity |= mask;
    + fallthrough;
    case IRQ_TYPE_EDGE_FALLING:
    case IRQ_TYPE_EDGE_BOTH:
    break;
    diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
    index 834a12f3219e..23fa9df8241d 100644
    --- a/drivers/gpio/gpiolib-acpi.c
    +++ b/drivers/gpio/gpiolib-acpi.c
    @@ -548,6 +548,7 @@ acpi_gpio_to_gpiod_flags(const struct acpi_resource_gpio *agpio)
    default:
    break;
    }
    + break;
    default:
    break;
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:27    [W:2.223 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site