lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 048/141] perf/x86: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    by explicitly adding a fallthrough pseudo-keyword as a replacement for
    a /* fall through */ comment, instead of letting the code fall through
    to the next case.

    Notice that Clang doesn't recognize /* fall through */ comments as
    implicit fall-through markings.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    arch/x86/events/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
    index a88c94d65693..550c5e7002b9 100644
    --- a/arch/x86/events/core.c
    +++ b/arch/x86/events/core.c
    @@ -1174,7 +1174,7 @@ static inline void x86_assign_hw_event(struct perf_event *event,
    case INTEL_PMC_IDX_METRIC_BASE ... INTEL_PMC_IDX_METRIC_END:
    /* All the metric events are mapped onto the fixed counter 3. */
    idx = INTEL_PMC_IDX_FIXED_SLOTS;
    - /* fall through */
    + fallthrough;
    case INTEL_PMC_IDX_FIXED ... INTEL_PMC_IDX_FIXED_BTS-1:
    hwc->config_base = MSR_ARCH_PERFMON_FIXED_CTR_CTRL;
    hwc->event_base = MSR_ARCH_PERFMON_FIXED_CTR0 +
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:4.102 / U:2.980 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site