lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 001/141] afs: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple fallthrough pseudo-keywords
in places where the code is intended to fall through to the next
case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
fs/afs/cmservice.c | 5 +++++
fs/afs/fsclient.c | 4 ++++
fs/afs/vlclient.c | 1 +
3 files changed, 10 insertions(+)

diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c
index a4e9e6e07e93..d17b31dfe63f 100644
--- a/fs/afs/cmservice.c
+++ b/fs/afs/cmservice.c
@@ -322,6 +322,8 @@ static int afs_deliver_cb_callback(struct afs_call *call)
return ret;

call->unmarshall++;
+
+ fallthrough;
case 5:
break;
}
@@ -419,6 +421,7 @@ static int afs_deliver_cb_init_call_back_state3(struct afs_call *call)

call->unmarshall++;

+ fallthrough;
case 2:
break;
}
@@ -531,6 +534,7 @@ static int afs_deliver_cb_probe_uuid(struct afs_call *call)

call->unmarshall++;

+ fallthrough;
case 2:
break;
}
@@ -664,6 +668,7 @@ static int afs_deliver_yfs_cb_callback(struct afs_call *call)
afs_extract_to_tmp(call);
call->unmarshall++;

+ fallthrough;
case 3:
break;
}
diff --git a/fs/afs/fsclient.c b/fs/afs/fsclient.c
index 1d95ed9dd86e..a00eaa155012 100644
--- a/fs/afs/fsclient.c
+++ b/fs/afs/fsclient.c
@@ -405,6 +405,7 @@ static int afs_deliver_fs_fetch_data(struct afs_call *call)
req->file_size = vp->scb.status.size;

call->unmarshall++;
+ fallthrough;

case 5:
break;
@@ -1444,6 +1445,7 @@ static int afs_deliver_fs_get_volume_status(struct afs_call *call)
_debug("motd '%s'", p);

call->unmarshall++;
+ fallthrough;

case 8:
break;
@@ -1881,6 +1883,7 @@ static int afs_deliver_fs_inline_bulk_status(struct afs_call *call)
xdr_decode_AFSVolSync(&bp, &op->volsync);

call->unmarshall++;
+ fallthrough;

case 6:
break;
@@ -2015,6 +2018,7 @@ static int afs_deliver_fs_fetch_acl(struct afs_call *call)
xdr_decode_AFSVolSync(&bp, &op->volsync);

call->unmarshall++;
+ fallthrough;

case 4:
break;
diff --git a/fs/afs/vlclient.c b/fs/afs/vlclient.c
index dc9327332f06..29930ea16652 100644
--- a/fs/afs/vlclient.c
+++ b/fs/afs/vlclient.c
@@ -594,6 +594,7 @@ static int afs_deliver_yfsvl_get_endpoints(struct afs_call *call)
return ret;
call->unmarshall = 6;

+ fallthrough;
case 6:
break;
}
--
2.27.0
\
 
 \ /
  Last update: 2020-11-20 19:27    [W:1.779 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site