lkml.org 
[lkml]   [2020]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 001/141] afs: Fix fall-through warnings for Clang
Date
Joe Perches <joe@perches.com> wrote:

> > My preference would be to fall through. The case number is the state machine
> > state, as indexed by call->unmarshall.
>
> Then ideally the state machine states should be enums and not numbers
> and the compiler should use a default block for unhandled states right?
>
> Is code like call->marshall++ a common style for kernel state machines?
> Perhaps not.

How the value is interpreted is unique to each delivery function, of which
there are a number, since it counts out the separate parts of the xdr encoding
for that particular RPC request or reply block.

Maybe "state machine" isn't the right term.

David

\
 
 \ /
  Last update: 2020-11-24 14:25    [W:0.262 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site