[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 001/141] afs: Fix fall-through warnings for Clang
On Fri, 2020-11-20 at 17:28 -0600, Gustavo A. R. Silva wrote:
> On 11/20/20 17:18, Joe Perches wrote:
> > My preference would be to change these to break and not fallthrough;
> And my preference is fallthrough.

If so, that's an unusual choice here as it seems most or all of
the other patches you submitted use break in the same situation
where the next case is a single line break;

see: patches 2, 3, 4, 8, 9, etc...

> Joe, please, let the maintainer share their opinion on this first.

My preferences are my preferences and I don't mind announcing them.

 \ /
  Last update: 2020-11-21 00:43    [W:0.184 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site