lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 008/141] IB/hfi1: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements instead of just
    letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/infiniband/hw/hfi1/qp.c | 1 +
    drivers/infiniband/hw/hfi1/tid_rdma.c | 5 +++++
    2 files changed, 6 insertions(+)

    diff --git a/drivers/infiniband/hw/hfi1/qp.c b/drivers/infiniband/hw/hfi1/qp.c
    index 356518e17fa6..681bb4e918c9 100644
    --- a/drivers/infiniband/hw/hfi1/qp.c
    +++ b/drivers/infiniband/hw/hfi1/qp.c
    @@ -339,6 +339,7 @@ int hfi1_setup_wqe(struct rvt_qp *qp, struct rvt_swqe *wqe, bool *call_send)
    return -EINVAL;
    if (ibp->sl_to_sc[rdma_ah_get_sl(&ah->attr)] == 0xf)
    return -EINVAL;
    + break;
    default:
    break;
    }
    diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c
    index 73d197e21730..92aa2a9b3b5a 100644
    --- a/drivers/infiniband/hw/hfi1/tid_rdma.c
    +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
    @@ -2826,6 +2826,7 @@ static bool handle_read_kdeth_eflags(struct hfi1_ctxtdata *rcd,
    default:
    break;
    }
    + break;
    default:
    break;
    }
    @@ -3005,6 +3006,7 @@ bool hfi1_handle_kdeth_eflags(struct hfi1_ctxtdata *rcd,
    default:
    break;
    }
    + break;
    default:
    break;
    }
    @@ -3221,6 +3223,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe)
    req = wqe_to_tid_req(prev);
    if (req->ack_seg != req->total_segs)
    goto interlock;
    + break;
    default:
    break;
    }
    @@ -3239,9 +3242,11 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe)
    req = wqe_to_tid_req(prev);
    if (req->ack_seg != req->total_segs)
    goto interlock;
    + break;
    default:
    break;
    }
    + break;
    default:
    break;
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:27    [W:6.617 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site