lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 117/141] rtl8xxxu: Fix fall-through warnings for Clang
    Date
    On 11/20/20 1:38 PM, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix
    > multiple warnings by replacing /* fall through */ comments with
    > the new pseudo-keyword macro fallthrough; instead of letting the
    > code fall through to the next case.
    >
    > Notice that Clang doesn't recognize /* fall through */ comments as
    > implicit fall-through markings.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)

    While I wasn't CC'ed on the cover-letter I see Jakub also raised issues
    about this unnecessary patch noise.

    Quite frankly, this seems to be patch churn for the sake of patch churn.
    If clang is broken, fix clang instead.

    NACK


    Jes

    > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
    > index 5cd7ef3625c5..afc97958fa4d 100644
    > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
    > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
    > @@ -1145,7 +1145,7 @@ void rtl8xxxu_gen1_config_channel(struct ieee80211_hw *hw)
    > switch (hw->conf.chandef.width) {
    > case NL80211_CHAN_WIDTH_20_NOHT:
    > ht = false;
    > - /* fall through */
    > + fallthrough;
    > case NL80211_CHAN_WIDTH_20:
    > opmode |= BW_OPMODE_20MHZ;
    > rtl8xxxu_write8(priv, REG_BW_OPMODE, opmode);
    > @@ -1272,7 +1272,7 @@ void rtl8xxxu_gen2_config_channel(struct ieee80211_hw *hw)
    > switch (hw->conf.chandef.width) {
    > case NL80211_CHAN_WIDTH_20_NOHT:
    > ht = false;
    > - /* fall through */
    > + fallthrough;
    > case NL80211_CHAN_WIDTH_20:
    > rf_mode_bw |= WMAC_TRXPTCL_CTL_BW_20;
    > subchannel = 0;
    > @@ -1741,11 +1741,11 @@ static int rtl8xxxu_identify_chip(struct rtl8xxxu_priv *priv)
    > case 3:
    > priv->ep_tx_low_queue = 1;
    > priv->ep_tx_count++;
    > - /* fall through */
    > + fallthrough;
    > case 2:
    > priv->ep_tx_normal_queue = 1;
    > priv->ep_tx_count++;
    > - /* fall through */
    > + fallthrough;
    > case 1:
    > priv->ep_tx_high_queue = 1;
    > priv->ep_tx_count++;
    >

    \
     
     \ /
      Last update: 2020-11-20 22:42    [W:4.109 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site