lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 002/141] ASoC: codecs: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements instead of just
    letting the code fall through, and also add fallthrough pseudo-keywords
    in places where the code is intended to fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    sound/soc/codecs/adav80x.c | 1 +
    sound/soc/codecs/arizona.c | 1 +
    sound/soc/codecs/cs42l52.c | 1 +
    sound/soc/codecs/cs42l56.c | 1 +
    sound/soc/codecs/cs47l92.c | 1 +
    sound/soc/codecs/wm8962.c | 1 +
    6 files changed, 6 insertions(+)

    diff --git a/sound/soc/codecs/adav80x.c b/sound/soc/codecs/adav80x.c
    index 4fd99280d7db..75a649108106 100644
    --- a/sound/soc/codecs/adav80x.c
    +++ b/sound/soc/codecs/adav80x.c
    @@ -373,6 +373,7 @@ static int adav80x_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
    case SND_SOC_DAIFMT_CBM_CFM:
    capture |= ADAV80X_CAPTURE_MODE_MASTER;
    playback |= ADAV80X_PLAYBACK_MODE_MASTER;
    + break;
    case SND_SOC_DAIFMT_CBS_CFS:
    break;
    default:
    diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
    index 1228f2de0297..e32871b3f68a 100644
    --- a/sound/soc/codecs/arizona.c
    +++ b/sound/soc/codecs/arizona.c
    @@ -1034,6 +1034,7 @@ int arizona_out_ev(struct snd_soc_dapm_widget *w,
    priv->out_down_delay++;
    break;
    }
    + break;
    default:
    break;
    }
    diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c
    index f772628f233e..796b894c390f 100644
    --- a/sound/soc/codecs/cs42l52.c
    +++ b/sound/soc/codecs/cs42l52.c
    @@ -944,6 +944,7 @@ static int cs42l52_beep_event(struct input_dev *dev, unsigned int type,
    case SND_BELL:
    if (hz)
    hz = 261;
    + break;
    case SND_TONE:
    break;
    default:
    diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c
    index 97024a6ac96d..bb9599cc832b 100644
    --- a/sound/soc/codecs/cs42l56.c
    +++ b/sound/soc/codecs/cs42l56.c
    @@ -1008,6 +1008,7 @@ static int cs42l56_beep_event(struct input_dev *dev, unsigned int type,
    case SND_BELL:
    if (hz)
    hz = 261;
    + break;
    case SND_TONE:
    break;
    default:
    diff --git a/sound/soc/codecs/cs47l92.c b/sound/soc/codecs/cs47l92.c
    index 6e34106c268f..52dc29942ec2 100644
    --- a/sound/soc/codecs/cs47l92.c
    +++ b/sound/soc/codecs/cs47l92.c
    @@ -201,6 +201,7 @@ static int cs47l92_outclk_ev(struct snd_soc_dapm_widget *w,
    default:
    break;
    }
    + break;
    default:
    break;
    }
    diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
    index 0bd3bbc2aacf..3af456010b9c 100644
    --- a/sound/soc/codecs/wm8962.c
    +++ b/sound/soc/codecs/wm8962.c
    @@ -3203,6 +3203,7 @@ static int wm8962_beep_event(struct input_dev *dev, unsigned int type,
    case SND_BELL:
    if (hz)
    hz = 1000;
    + fallthrough;
    case SND_TONE:
    break;
    default:
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:27    [W:4.101 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site