lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 004/141] drm/amdgpu: Fix fall-through warnings for Clang
    On Fri, Nov 20, 2020 at 1:24 PM Gustavo A. R. Silva
    <gustavoars@kernel.org> wrote:
    >
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    > warnings by explicitly adding multiple break statements instead of just
    > letting the code fall through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 +
    > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 1 +
    > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 +
    > drivers/gpu/drm/amd/amdgpu/vi.c | 1 +
    > 4 files changed, 4 insertions(+)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
    > index 3579565e0eab..98ca6b976b6e 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
    > @@ -8398,6 +8398,7 @@ static int gfx_v10_0_set_priv_inst_fault_state(struct amdgpu_device *adev,
    > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0,
    > PRIV_INSTR_INT_ENABLE,
    > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0);
    > + break;
    > default:
    > break;
    > }
    > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
    > index 0d8e203b10ef..e61121629b93 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
    > @@ -5683,6 +5683,7 @@ static int gfx_v9_0_set_priv_inst_fault_state(struct amdgpu_device *adev,
    > WREG32_FIELD15(GC, 0, CP_INT_CNTL_RING0,
    > PRIV_INSTR_INT_ENABLE,
    > state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0);
    > + break;
    > default:
    > break;
    > }
    > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
    > index 3ebbddb63705..584b99b80c29 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
    > @@ -502,6 +502,7 @@ static int gmc_v9_0_vm_fault_interrupt_state(struct amdgpu_device *adev,
    > WREG32(reg, tmp);
    > }
    > }
    > + break;
    > default:
    > break;
    > }
    > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
    > index 9bcd0eebc6d7..d56b474b3a21 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/vi.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
    > @@ -1645,6 +1645,7 @@ static int vi_common_set_clockgating_state(void *handle,
    > case CHIP_POLARIS12:
    > case CHIP_VEGAM:
    > vi_common_set_clockgating_state_by_smu(adev, state);
    > + break;
    > default:
    > break;
    > }
    > --
    > 2.27.0
    >
    > _______________________________________________
    > amd-gfx mailing list
    > amd-gfx@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/amd-gfx

    \
     
     \ /
      Last update: 2020-11-20 23:44    [W:2.902 / U:1.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site